Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-7397 PLT-7398 PLT-7399 Revisions to tests for new validators #710

Merged
merged 5 commits into from Sep 10, 2023
Merged

PLT-7397 PLT-7398 PLT-7399 Revisions to tests for new validators #710

merged 5 commits into from Sep 10, 2023

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Sep 10, 2023

  1. Changes to the tests that check validator hashes and size.
  2. Updates to script registry.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@bwbush
PLT-7399 PLT-7397 Updated golden cases for safety analysis.
f82910b 
1. Updated golden cases for transaction-cost safet analyses.
2. Reviewed change in transaction cost for revised validators.
@bwbush
PLT-7399 Added missing plutus-trace flag for marlowe-test.
fa891e1
@bwbush
PLT-7398 PLT-7399 Published new Marlowe scripts.
537ece3 
1. Published new Marlowe scripts on mainnet, preprod, preview.
2. Updated script registry to use new scripts as "current".
3. Updated `marlowe-runtime-tests` tests that verify script hashes.
4. Updated `marlowe-test` tests that verify script hashes.
5. Updated `marlowe-test` test for script size.
6. Compared Plutus serialization of new scripts to that of old
   scripts. The vast majority of the bytes are the same, with
   only the beginning and ending different. This is because the
   typed validators are cast to a untyped validators without the
   use of the `plutus-apps` functions: instead these are cast
   manually.
7. Verified that the hashes of the validators are computed
   correctly by comparing to the output of `cardano-cli address build`.
@bwbush
PLT-7399 Reviewed and updated golden tests for MarloweTxCommand.
96f49e7
@bwbush bwbush self-assigned this Sep 10, 2023
@bwbush bwbush marked this pull request as ready for review September 10, 2023 19:08
@bwbush bwbush merged commit 579705e into plt-7884-x-plutus-apps Sep 10, 2023
2 of 4 checks passed
@bwbush bwbush deleted the PLT-7397 branch September 10, 2023 19:08
@bwbush bwbush restored the PLT-7397 branch September 10, 2023 19:08
@palas palas changed the title PLT-7397 PLT-7399 Revisions to tests for new validators PLT-7397 PLT-7398 PLT-7399 Revisions to tests for new validators Sep 16, 2023
@bwbush bwbush deleted the PLT-7397 branch November 21, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bwbush bwbush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bwbush