Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-7951 Remedied inconsistent parsing of seconds for different `marl… #759

Merged
merged 1 commit into from Nov 21, 2023

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Nov 21, 2023

Somewhat randomly, different --submit and --timeout flags in marlowe-cli either did or did not require the integer seconds to have an s suffix. This change makes them uniformly accept either an integer or an integer with an s suffix.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
    • Operables are updated with changes to executable command line options.
    • Deploy charts updated with changes to operables.
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@bwbush bwbush self-assigned this Nov 21, 2023
@bwbush bwbush merged commit eca14ae into main Nov 21, 2023
5 checks passed
@bwbush bwbush deleted the PLT-7951 branch November 21, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant