Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-8712 Add support for additional properties on token metadata #762

Merged
merged 6 commits into from Nov 27, 2023

Conversation

jhbertra
Copy link
Contributor

@jhbertra jhbertra commented Nov 23, 2023

  • Added support for additional properties to role token metadata.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
    • Operables are updated with changes to executable command line options.
    • Deploy charts updated with changes to operables.
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@jhbertra jhbertra requested a review from bwbush November 24, 2023 13:49
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make Marlowe Runtime fully compliant with CIP25 v1 metadata?

@jhbertra
Copy link
Contributor Author

Does this make Marlowe Runtime fully compliant with CIP25 v1 metadata?

Still no support for arbitrary additional properties on files, I can add that though.

@bwbush
Copy link
Collaborator

bwbush commented Nov 24, 2023

Still no support for arbitrary additional properties on files, I can add that though.

If it's not difficult, it's probably worth doing that, just so we're 100% compliant.

@jhbertra jhbertra force-pushed the plt-8712-minting-metadata-additional-props branch from bd09ee0 to 83f09c0 Compare November 27, 2023 13:08
@jhbertra jhbertra force-pushed the plt-8712-minting-metadata-additional-props branch from 0f25091 to 08aa0cd Compare November 27, 2023 15:46
@jhbertra jhbertra merged commit 4366ef9 into main Nov 27, 2023
5 checks passed
@jhbertra jhbertra deleted the plt-8712-minting-metadata-additional-props branch November 27, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants