Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provided state when running safety analysis (PLT-9308) #806

Merged
merged 1 commit into from Jan 21, 2024
Merged

Use provided state when running safety analysis (PLT-9308) #806

merged 1 commit into from Jan 21, 2024

Conversation

paluh
Copy link
Collaborator

@paluh paluh commented Jan 19, 2024

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
    • Operables are updated with changes to executable command line options.
    • Deploy charts updated with changes to operables.
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@paluh paluh requested a review from bwbush January 19, 2024 10:22
@paluh
Copy link
Collaborator Author

paluh commented Jan 19, 2024

Minor comment:
@bwbush the diff can be a bit misleading - I did not change contract in the original test scenario.

@paluh paluh merged commit e4391b6 into main Jan 21, 2024
6 checks passed
@paluh paluh deleted the PLT-9308 branch January 21, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paluh @bwbush