PLT-8148 Upgrade to Plutus 1.15.0.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwbush it is a bit hard to review the changes because this PR contains also rearrangement of the code and there are no diffs over these pieces. Should I assume that validators and semantics where not really changed? |
bwbush
commented
Nov 17, 2023
|
|
||
| marloweValidatorCompiled | ||
| :: PlutusTx.CompiledCode (ValidatorHash -> PlutusTx.BuiltinData -> PlutusTx.BuiltinData -> PlutusTx.BuiltinData -> ()) | ||
| marloweValidatorCompiled = Haskell.undefined |
* PLT-7584 Measurement of Plutus costs when suppressing parts of validation. * PLT-7585 Disabled `fourmolu` because it chokes on the C preprocessor. * PLT-7584 Fixed output file name. * Add options to fourmolu * Fix fourmolu2 --------- Co-authored-by: zeme <lorenzo.calegari@iohk.io>
…Data` (#10) PLT-7585 Ported `PlutusTx.AsData` validator from IntersectMBO/plutus@107c9a6.
|
@paluh and @palas, here is an efficient way to segment the history for review:
|
palas
approved these changes
Nov 22, 2023
paluh
reviewed
Nov 24, 2023
|
|
||
| PlutusTx.makeLift ''SubScriptContext | ||
| PlutusTx.makeIsDataIndexed ''SubScriptContext [('SubScriptContext, 0)] | ||
|
|
There was a problem hiding this comment.
We have to probably just drop this comment - it doesn't make sens any more.
paluh
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
I really appreciate that you made this AsData based implementation optional Brian. I really like that you preserved clean Haskell implementation of data types :-)
Of course this rises the question about maintenance cost and if we will use AsData based implementation at all ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Plutus to version 1.15.0.0 so that Marlowe can take advantage of the new compiler optimizations.
The Marlowe-Cardano test suite was run with
--qc-max-success 100000with no failures.