Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-6741 - Initial version of workspaces #10

Merged
merged 10 commits into from
Aug 9, 2023
Merged

PLT-6741 - Initial version of workspaces #10

merged 10 commits into from
Aug 9, 2023

Conversation

hrajchert
Copy link
Collaborator

@hrajchert hrajchert commented Aug 3, 2023

This PR separates the SDK into different packages using npm workspaces. Three things needs to work together for this to be successful

  • Package management:
    • The different packages needs to be maintained by a tool, in this case npm workspaces and the way the packages are linked should be coherent both in runtime and type level
  • TypeScript references:
    • The tsconfig use project reference and path aliases to correctly solve package linking
  • Runtime environment
    • This should be loadable both in Node.js and in the browser.

To test module resolve in the Node.js first build the project and then run

$ node test-nodejs-import.mjs 

To test module resolve in the browser, build the project and

# Serve the contents of the root folder
$ npx http-serve
# In the browser go to http://127.0.0.1:8080/web-rollup-esm-poc.html and inspect the console

The unit tests of the language module can be runned using

$ npm t

either in the root directory or in the proper package.

The e2e tests are not running because some issues with ts-jest
TODO: Compile and run tests

@hrajchert hrajchert marked this pull request as draft August 3, 2023 21:04
@hrajchert hrajchert marked this pull request as ready for review August 8, 2023 19:45
@nhenin nhenin merged commit 803ac6e into main Aug 9, 2023
1 check failed
@palas palas changed the title Initial version of workspaces PLT-6741 - Initial version of workspaces Aug 14, 2023
@palas palas deleted the workspaces branch August 18, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants