Split store_transactions in several database transactions.

input-output-hk · May 6, 2024 · fd07d28 · fd07d28
1 parent f3c9350
commit fd07d28
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 12 deletions.
diff --git a/mithril-aggregator/src/database/repository/cardano_transaction_repository.rs b/mithril-aggregator/src/database/repository/cardano_transaction_repository.rs
@@ -242,14 +242,19 @@ impl TransactionStore for CardanoTransactionRepository {
     }
 
     async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()> {
-        self.connection.execute("BEGIN TRANSACTION;")?;
-        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
-        for transactions_in_chunk in transactions.chunks(100) {
-            self.create_transactions(transactions_in_chunk.to_vec())
-                .await
-                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+        const DB_TRANSACTION_SIZE: usize = 100000;
+        for transactions_in_db_transaction_chunk in transactions.chunks(DB_TRANSACTION_SIZE) {
+            self.connection.execute("BEGIN TRANSACTION;")?;
+
+            // Chunk transactions to avoid an error when we exceed sqlite binding limitations
+            for transactions_in_chunk in transactions_in_db_transaction_chunk.chunks(100) {
+                self.create_transactions(transactions_in_chunk.to_vec())
+                    .await
+                    .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+            }
+
+            self.connection.execute("END TRANSACTION;")?;
         }
-        self.connection.execute("END TRANSACTION;")?;
         Ok(())
     }
 

diff --git a/mithril-signer/src/database/repository/cardano_transaction_repository.rs b/mithril-signer/src/database/repository/cardano_transaction_repository.rs
@@ -236,11 +236,18 @@ impl TransactionStore for CardanoTransactionRepository {
     }
 
     async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()> {
-        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
-        for transactions_in_chunk in transactions.chunks(100) {
-            self.create_transactions(transactions_in_chunk.to_vec())
-                .await
-                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+        const DB_TRANSACTION_SIZE: usize = 100000;
+        for transactions_in_db_transaction_chunk in transactions.chunks(DB_TRANSACTION_SIZE) {
+            self.connection.execute("BEGIN TRANSACTION;")?;
+
+            // Chunk transactions to avoid an error when we exceed sqlite binding limitations
+            for transactions_in_chunk in transactions_in_db_transaction_chunk.chunks(100) {
+                self.create_transactions(transactions_in_chunk.to_vec())
+                    .await
+                    .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+            }
+
+            self.connection.execute("END TRANSACTION;")?;
         }
         Ok(())
     }