Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connections coupling with providers in database #1711

Closed
3 tasks done
jpraynaud opened this issue May 24, 2024 · 0 comments · Fixed by #1715
Closed
3 tasks done

Remove connections coupling with providers in database #1711

jpraynaud opened this issue May 24, 2024 · 0 comments · Fixed by #1715
Assignees
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented May 24, 2024

Why

We need to make the providers capable of returning an iterator alongside of a collection. The providers are currently using the database connection which prevents this operation to be done easily (in particular because of lifetime issues).

What

Remove the connection from the all the providers in the Mithril nodes and rename them to a more appropriate name (as they will not provide anything anymore).

How

  • Remove connection from the providers in mithril-persistence and rename to query
  • Remove connection from the providers in aggregator and rename to query
  • Remove connection from the providers in signer and rename to query

Later

  • Assess the existing repositories where we could benefit from an iterator (memory consumption optimization)
  • Implement the iterators to optimize memory consumption
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants