Simplify aggregator integration tests #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/simplify_aggregator_integration_tests
branch
from
d7bf13a
to
04111cc
Compare
Right now it's now only used by tests to assert that a given signed entity was created with the last certificate.
This simplify test by shifting the responsability of getting the data to check to the tests toolings, also it makes more visual what we expect making reading those tests less cumbersome.
Alenar
force-pushed
the
djo/simplify_aggregator_integration_tests
branch
from
04111cc
to
6f692cc
Compare
Alenar
force-pushed
the
djo/simplify_aggregator_integration_tests
branch
from
6f692cc
to
4e2ad16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR simplify the integration tests of the aggregator by replacing most asserts by a new macro
assert_last_certificate_eq.Before we to manually get multiple information in the tested aggregator to do our assertion, the new mactro streamlined this and a new type,
ExpectedCertificate, allow to specify the subset of data that is meaningful to verify in a Certificate.Pre-submit checklist
Comments
To make the new macro work the capacity to get a
SignedEntityby its Certificate id had to be added to theSignedEntityStorer.