Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darwin nix build #1008

Merged
merged 2 commits into from Jun 27, 2023
Merged

Fix darwin nix build #1008

merged 2 commits into from Jun 27, 2023

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Jun 26, 2023

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@jbgi jbgi marked this pull request as draft June 26, 2023 08:45
@jbgi jbgi force-pushed the jbgi/darwin-fix branch 2 times, most recently from 895504b to 7bd8515 Compare June 26, 2023 08:56
@jbgi jbgi temporarily deployed to testing-preview June 26, 2023 09:16 — with GitHub Actions Inactive
@jbgi jbgi self-assigned this Jun 26, 2023
@jbgi jbgi marked this pull request as ready for review June 27, 2023 09:53
jpraynaud
jpraynaud approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbgi jbgi temporarily deployed to testing-preview June 27, 2023 10:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 5e53a67 into main Jun 27, 2023
26 of 31 checks passed
@jpraynaud jpraynaud deleted the jbgi/darwin-fix branch June 27, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@jbgi jbgi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbgi @jpraynaud