Aggregator Recompute cert hash command #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Alenar
force-pushed
the
djo/1001/recompute-cert-hash-command
branch
2 times, most recently
from
6186c83
to
15fb254
Compare
Alenar
force-pushed
the
djo/1001/recompute-cert-hash-command
branch
from
15fb254
to
c428bd6
Compare
jpraynaud
requested changes
Jun 28, 2023
jpraynaud
reviewed
Jun 28, 2023
Before it updated the previous hash **after** the computation of the new **hash** but it's silly since the previous hash is taken into account to compute the new hash.
Alenar
force-pushed
the
djo/1001/recompute-cert-hash-command
branch
from
c428bd6
to
335ea99
Compare
This speed up certificates insertion on a db with 1800+ certificates by a factor of 5+ (8s instead of 44s).
ghubertpalo
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a new commands that make the aggregator recompute all its certificates hash (and update certificate related entities such as
signed_entity).This allow us to change the structure of the
CertificateandCertificateMetadatatypes without the needs to re-genesis the certificate chain.Pre-submit checklist
Comments
This PR also split the aggregator commands arguments in a dedicated sub-module/
Issue(s)
Closes #1001