Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full feature to mithril-common #1383

Merged
merged 2 commits into from Dec 5, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 1, 2023

Content

This PR adds the full feature to mithril-common so that it does not break the CI with publication to crates.io checks.

Note

The full feature does nothing at the moment, and will be activated in PR #1368

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1336

@jpraynaud jpraynaud self-assigned this Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Test Results

    3 files  ±0    30 suites  ±0   7m 32s ⏱️ +5s
745 tests ±0  745 ✔️ ±0  0 💤 ±0  0 ±0 
853 runs  ±0  853 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e8cac05. ± Comparison against base commit 426b764.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud merged commit c609e05 into main Dec 5, 2023
33 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1336-add-common-full-feature branch December 5, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants