Sfa/improve signed entity test

[sfauvel]

Content

Simplification proposal for signed_entity tests to improve understanding by hiding some technical code.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Comments

To hide code needed to handle mocks, a MockDependencyInjector struct is added.
It creates and keeps all mocks needed during tests.
It provide functions that build struct with mocks.

Issue(s)

Relates to #YYY or Closes #YYY

[jpraynaud]

It looks like your branch is far behind as there should also be a build_artifact_for_cardano_transactions_store_nothing_in_db test to adapt in this module 🤔

Otherwise LGTM 👍

[sfauvel]

It looks like your branch is far behind as there should also be a build_artifact_for_cardano_transactions_store_nothing_in_db test to adapt in this module 🤔

Otherwise LGTM 👍

I rebased to main

[sfauvel]

I add 3 versions of the same test on create_artifact.
We have to choose the version to keep.

• 3 independent tests, 1 for each artifact
• 1 test that test create_artifact for each of the 3 artifacts
• Create a generic function that test 1 artifact. This function can be used in one test or in 3 independent tests.

[jpraynaud]

LGTM 👍

[Alenar]

LGTM 🚀

[jpraynaud]

It looks like the cargo fmt is not happy yet 🙂
https://github.com/input-output-hk/mithril/actions/runs/7724637715/job/21059899630#step:6:18

[jpraynaud]

@sfauvel can you fix the clippy warning and bump the patch version of the aggregator?
That's all that is missing before we can merge the PR 🙂