Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed end to end tests artifact names #1472

Merged
merged 1 commit into from Jan 30, 2024
Merged

Failed end to end tests artifact names #1472

merged 1 commit into from Jan 30, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 30, 2024 •
edited

Content

This PR includes a fix to the naming of failed artifacts in the end to end CI.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jan 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited

Test Results

  3 files  ±0   33 suites  ±0   8m 44s ⏱️ -1s
784 tests ±0  784 ✅ ±0  0 💤 ±0  0 ❌ ±0 
857 runs  ±0  857 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7ba172a. ± Comparison against base commit 5945700.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-e2e-fails-artifacts branch from ed281b2 to 7ba172a Compare January 30, 2024 08:43
dlachaume
dlachaume approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit 659da2e into main Jan 30, 2024
39 of 40 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-e2e-fails-artifacts branch January 30, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpraynaud @Alenar @dlachaume