Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CardanoTransactions proof generation route in aggregator #1473

Merged
merged 17 commits into from Jan 31, 2024
Merged

Implement CardanoTransactions proof generation route in aggregator #1473

merged 17 commits into from Jan 31, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 30, 2024 •
edited

Content

This PR includes the new route in the aggregator REST API which generates cryptographic proofs for Cardano transactions.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1467

@jpraynaud
chore: update OpenAPI for proof generation route
35e3272
@jpraynaud
chore: create TransactionsSetProof entity type in aggregator
af71ec4
@jpraynaud
chore: create a ProverService trait in aggregator
f575524
@jpraynaud
chore: add prover service in dependency injection
734b9cb
@jpraynaud
chore: move and rename CardanoTransactionsSetProof to common
67de0af
@jpraynaud
chore: add CardanoTransactionsProofsMessage message in common
2e6e874
@jpraynaud
chore: add ToCardanoTransactionsProofsMessageAdapter adapter in aggre…
e5045ae 
…gator
@jpraynaud
fix: add missing traits to MKTreeNode
7526d3b
@jpraynaud
feat: MKProof is able to check if leaves are included
602eca4
@jpraynaud
feat: add Cardano transactions set proof verification
9895d50
@jpraynaud
chore: implement cardano transactions proof message adapter
cf3c313
@jpraynaud
feat: implementation of Mithril prover for Cardano transactions
5bea836
@jpraynaud
feat: implement TransactionsRetriever trait for CardanoTransactionsRe…
a66f248 
…pository
@jpraynaud
feat: implement proof generation route
04291de
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited

Test Results

  3 files  ± 0   33 suites  ±0   8m 47s ⏱️ +4s
798 tests +11  798 ✅ +11  0 💤 ±0  0 ❌ ±0 
871 runs  +11  871 ✅ +11  0 💤 ±0  0 ❌ ±0 

Results for commit 0a71dec. ± Comparison against base commit ec8910b.

♻️ This comment has been updated with latest results.

@jpraynaud
chore: update crates versions
f5140a1 
- mithril-aggregator: from '0.4.29' to '0.4.30'.
- mithril-common: from '0.2.156' to '0.2.157'.
@jpraynaud
chore: update OpenAPI version
0a71dec 
From '0.1.13' to '0.1.14'.
@jpraynaud jpraynaud merged commit d8b1ea6 into main Jan 31, 2024
39 checks passed
@jpraynaud jpraynaud deleted the ensemble/1467-transactions-proof-route-aggregator branch January 31, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@Alenar Alenar

@jpraynaud jpraynaud

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement proof generation route in the aggregator
3 participants
@jpraynaud @Alenar @dlachaume