Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix end to end test flakiness in CI #1486

Merged
merged 28 commits into from
Feb 23, 2024
Merged

Fix end to end test flakiness in CI #1486

merged 28 commits into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. fix: first launch protocol parameters setup in e2e test 

    Attempt to fix temporal effects at startup (fast epochs) resulting in
error: '`mithril-aggregator genesis bootstrap` exited with code: 1'
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    332b184 View commit details
    Browse the repository at this point in the history

  2. fix: record one more epoch at first launch protocol in e2e test 

    Attempt to fix temporal effects at startup (fast epochs) resulting in
error: '`mithril-aggregator genesis bootstrap` exited with code: 1'
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2d1d85a View commit details
    Browse the repository at this point in the history

  3. refactor: get rid of 'ProtocolParametersStore' in aggregator 

    This legacy implementation is replaced by a fake implementation of the
'ProtocolParametersStorer' trait, as it used for tests only.

Attempt to fix temporal effects at startup (fast epochs) resulting in
error: '`mithril-aggregator genesis bootstrap` exited with code: 1'
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b08d23a View commit details
    Browse the repository at this point in the history

  4. fix: enhance protocol parameters bootstrap on first launch 

    Bootstrap protocol parameters on first launch only.

Attempt to fix temporal effects at startup (fast epochs) resulting in
error: '`mithril-aggregator genesis bootstrap` exited with code: 1'
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3bbd11b View commit details
    Browse the repository at this point in the history

  5. fix: enhance protocol parameters discrepancies handling 

    The discrepancy can occur not only at startup and not only on the 'serve' command.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7d0b944 View commit details
    Browse the repository at this point in the history

  6. feat: Mithril node run interval is configurable in e2e

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ba649f8 View commit details
    Browse the repository at this point in the history

  7. fix: tail more logs from nodes to see full panic stack trace in e2e test 

    Tail last 40 lines instead of 20 lines.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9e071ae View commit details
    Browse the repository at this point in the history

  8. fix: incorrect network topology for full nodes in 'devnet'

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    28d8abe View commit details
    Browse the repository at this point in the history

  9. fix: bootstrap era reader adapter starts at epoch 0

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a5270fa View commit details
    Browse the repository at this point in the history

  10. fix: update security param in devnet 

    This was responsible a source of flakiness in the e2e test.
This lead to Cardano nodes running on different divergent forks,
and created panic on era reader which did not retrieve any marker.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e65ef39 View commit details
    Browse the repository at this point in the history

  11. fix: update active slots coeff in devnet 

    This was responsible for flakiness in the network with low values
of slot length and epoch length (such as those used in the E2E test).
It was responsible for era markers readers retrieving no values and
panicking.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9498a85 View commit details
    Browse the repository at this point in the history

  12. refactor: replace full nodes with SPO nodes in e2e test

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    32a0657 View commit details
    Browse the repository at this point in the history

  13. feat: add passive relays in e2e test 

    This avoids flakiness due to 'InsufficientPeers' errors from the P2P network.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4daba5f View commit details
    Browse the repository at this point in the history

  14. feat: make passive relays use optional in e2e

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dc32a7f View commit details
    Browse the repository at this point in the history

  15. fix: update idle connection timeout in P2P swarm config of relay 

    Use  instead of the default value, to avoid 'InsufficientPeers' errors in the P2P network.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    99a5ccd View commit details
    Browse the repository at this point in the history

  16. fix: update e2e protocol parameters 

    Attempt to avoid not reaching the quorum in some rare cases.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    91a9975 View commit details
    Browse the repository at this point in the history

  17. chore: debug signature message sent by relay to aggregator

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0eb05c4 View commit details
    Browse the repository at this point in the history

  18. fix: extend wait for transaction confirmation in devnet 

    Use the security parameter value ('10') to make sure that transaction is synchornized on all Cardano nodes.
This avoids getting some nodes panic at startup beacuse of empty era markers retrieval.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fd9b453 View commit details
    Browse the repository at this point in the history

  19. fix: add retry for relay posting signatures to aggregator

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    784dc0f View commit details
    Browse the repository at this point in the history

  20. fix: add retry for Mithril era markers transactions in devnet 

    This will avoid panic on Mithril nodes in case of rollback, which results in empty markers on chain.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    864728b View commit details
    Browse the repository at this point in the history

  21. make E2E clap check a min number of pool nodes

    @Alenar @jpraynaud
    Alenar authored and jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d9ae053 View commit details
    Browse the repository at this point in the history

  22. Refactor E2E infrastructure::start to split it in manageable parts

    @Alenar @jpraynaud
    Alenar authored and jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    604a196 View commit details
    Browse the repository at this point in the history

  23. Remove Bft nodes from mithril-end-to-end crate

    @Alenar @jpraynaud
    Alenar authored and jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    05cf028 View commit details
    Browse the repository at this point in the history

  24. fix: clap check of minimum number of pool nodes is too strict

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1dd6a16 View commit details
    Browse the repository at this point in the history

  25. fix: make payments script resilient to roll-backs in 'devnet'

    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4c67508 View commit details
    Browse the repository at this point in the history

  26. fix: transfer funds earlier in the e2e test 

    We currently sign the penultimate immutable chunk, which means that transactions
could either be in the ultimate immutable chunk or in the volatile db, thus not signed
by Mithril. This has lead to having only a subset of the submitted transactions
verified by the client.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8789d08 View commit details
    Browse the repository at this point in the history

  27. fix: force number of BFT nodes to 0 in e2e 'devnet' 

    This will avoid to have an unnecessary BFT node running in the devnet when started from the e2e test.
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4e264fe View commit details
    Browse the repository at this point in the history

  28. chore: bump crates versions 

    - 'mithril-aggregator' from '0.4.39' to '0.4.40'
- 'mithril-common' from '0.3.7' to 0.3.8'
- 'mithril-relay' from '0.1.11' to '0.1.12'
- 'mithril-enn-to-end' from '0.3.3' to '0.4.0'
- 'mithril-devnet' from '0.3.0' to '0.3.1'
    @jpraynaud
    jpraynaud committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fa5e910 View commit details
    Browse the repository at this point in the history