Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new npm package step dedicated to release process (latest tag) #1545

Merged
merged 3 commits into from Mar 6, 2024
Merged

Add new npm package step dedicated to release process (latest tag) #1545

merged 3 commits into from Mar 6, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Mar 4, 2024 •
edited

Content

This PR includes an update of the publish-wasm-package workflow.
A new step has been added to manage the promote to the latest tag on the npm package version when a new distribution is released.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1531

@dlachaume dlachaume changed the title Add new npm package step dedicated to release process Add new npm package step dedicated to release process (latest tag) Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited

Test Results

  3 files  ±0   42 suites  ±0   8m 27s ⏱️ -1s
909 tests ±0  909 ✅ ±0  0 💤 ±0  0 ❌ ±0 
998 runs  ±0  998 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 90d5402. ± Comparison against base commit 1c6c5e6.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch from eaf5bd2 to e0c050b Compare March 5, 2024 15:22
@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch from e0c050b to 94e6758 Compare March 5, 2024 15:41
@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch from 94e6758 to 6264c10 Compare March 5, 2024 15:57
@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch from 6264c10 to 38ffd90 Compare March 5, 2024 16:06
@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch 2 times, most recently from 1045f43 to 2b1cb68 Compare March 5, 2024 16:42
jpraynaud
jpraynaud approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left one last suggestion below.

.github/workflows/actions/publish-npm-package/action.yml Show resolved Hide resolved
@dlachaume dlachaume force-pushed the ensemble/1531/fix-npm-publish-when-release branch from 2b1cb68 to 90d5402 Compare March 6, 2024 10:46
@dlachaume dlachaume merged commit b505a58 into main Mar 6, 2024
38 checks passed
@dlachaume dlachaume deleted the ensemble/1531/fix-npm-publish-when-release branch March 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm publish fails on latest when next exists
4 participants
@dlachaume @Alenar @jpraynaud @sfauvel