Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and persist slot_number and block_hash to CardanoTransaction #1607

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Apr 2, 2024

Content

This PR add two new fields to our CardanoTransaction type: slot_number and block_hash. This will allow comparison between a transaction and their incoming beacon that will include them (and the block_number that's already a part of our transaction type).

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

To update the database provider part of the mithril-signer we simply copy-pasted the update one from the aggregator, adapted the import and removed the part that implemented traits not defined in the signer.
We choose to keep all the remaining code even if it's not used in the signer in order to keep as much as possible a parity between the aggregator and the signer file as long as they're still manipulating the same data.

Issue(s)

Relates to #1591

Copy link

github-actions bot commented Apr 2, 2024

Test Results

    3 files  ±0     42 suites  ±0   10m 14s ⏱️ + 1m 40s
  946 tests +3    946 ✅ +3  0 💤 ±0  0 ❌ ±0 
1 040 runs  +3  1 040 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit a869994. ± Comparison against base commit 0d4cace.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel force-pushed the ensemble/1591/incremental-storage-for-cardano-tx branch from 59ea0ad to 8cc9e95 Compare April 2, 2024 08:54
@Alenar Alenar marked this pull request as ready for review April 2, 2024 09:34
@sfauvel sfauvel temporarily deployed to testing-sanchonet April 2, 2024 09:41 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, otherwise LGTM 🚀

@sfauvel sfauvel force-pushed the ensemble/1591/incremental-storage-for-cardano-tx branch from 3f1e93c to 3ee8398 Compare April 2, 2024 14:14
@sfauvel sfauvel temporarily deployed to testing-sanchonet April 2, 2024 14:21 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the ensemble/1591/incremental-storage-for-cardano-tx branch from 3ee8398 to a869994 Compare April 2, 2024 14:23
@sfauvel sfauvel temporarily deployed to testing-sanchonet April 2, 2024 14:31 — with GitHub Actions Inactive
@Alenar Alenar merged commit 733d002 into main Apr 2, 2024
42 checks passed
@Alenar Alenar deleted the ensemble/1591/incremental-storage-for-cardano-tx branch April 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants