Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SQL migration tool #540

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

ghubertpalo
Copy link
Collaborator

Content

This PR removes migration tools (and associated libraries) from JSON → SQLite3.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #539

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

Unit Test Results

    7 files  ±0    22 suites   - 2   2m 3s ⏱️ -3s
334 tests  - 6  334 ✔️  - 6  0 💤 ±0  0 ±0 
335 runs   - 6  335 ✔️  - 6  0 💤 ±0  0 ±0 

Results for commit 54c2a3f. ± Comparison against base commit 978f15f.

This pull request removes 6 tests.
src/store/adapter_migration.rs - store::adapter_migration ‑ AdapterMigration (line 79)
store::adapter_migration::tests ‑ test_check_different_values
store::adapter_migration::tests ‑ test_check_key_not_exist
store::adapter_migration::tests ‑ test_check_keys_unaligned
store::adapter_migration::tests ‑ test_check_ok
store::adapter_migration::tests ‑ test_migration

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit 2116739 into main Oct 12, 2022
@ghubertpalo ghubertpalo deleted the greg/539/remove_migration_tool branch October 12, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove migration tool
2 participants