Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database migration framework #571

Merged
merged 15 commits into from
Nov 16, 2022
Merged

database migration framework #571

merged 15 commits into from
Nov 16, 2022

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Oct 26, 2022 •
edited by jpraynaud
Loading

Content

This PR provides a database model layer & stores the database schematic version in the database.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Closes #562

@github-actions
Copy link

github-actions bot commented Oct 27, 2022 •
edited
Loading

Unit Test Results

    3 files  ±0    28 suites  ±0   3m 2s ⏱️ +27s
335 tests +9  335 ✔️ +9  0 💤 ±0  0 ❌ ±0 
388 runs  +9  388 ✔️ +9  0 💤 ±0  0 ❌ ±0 

Results for commit c5d2dfe. ± Comparison against base commit 0bff212.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the greg/562/database_migration branch 2 times, most recently from 035497b to 27e9eee Compare November 8, 2022 13:38
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 8, 2022 15:47 Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 14, 2022 11:03 Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 14, 2022 13:31 Inactive
@ghubertpalo ghubertpalo force-pushed the greg/562/database_migration branch 2 times, most recently from 641dd03 to 14f9511 Compare November 15, 2022 14:48
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 15, 2022 15:20 Inactive
@ghubertpalo ghubertpalo force-pushed the greg/562/database_migration branch 2 times, most recently from e17517a to f47b541 Compare November 16, 2022 11:44
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 16, 2022 11:52 Inactive
jpraynaud
jpraynaud approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 16, 2022 15:36 Inactive
@ghubertpalo ghubertpalo merged commit b19074d into main Nov 16, 2022
@ghubertpalo ghubertpalo deleted the greg/562/database_migration branch November 16, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement stores migration process
2 participants
@ghubertpalo @jpraynaud