Update kes #674
Merged
Update kes #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files ±0 28 suites ±0 5m 18s ⏱️ + 2m 44s Results for commit b592b22. ± Comparison against base commit a43b1b8. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
iquerejeta
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
iquerejeta
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
approved these changes
Jan 4, 2023
Comment on lines
128
to
142
| if kes_sk_period <= provided_period { | ||
| // We need to perform the evolutions | ||
| for period in kes_sk_period..provided_period { | ||
| kes_sk | ||
| .update() | ||
| .map_err(|_| ProtocolInitializerErrorWrapper::KesUpdate(period))?; | ||
| } | ||
|
|
||
| Some(kes_sk.sign(&stm_initializer.verification_key().to_bytes())) | ||
| Some(kes_sk.sign(&stm_initializer.verification_key().to_bytes())) | ||
| } else { | ||
| return Err(ProtocolInitializerErrorWrapper::KesMismatch( | ||
| kes_sk_period, | ||
| provided_period, | ||
| )); | ||
| } |
There was a problem hiding this comment.
Maybe you could first check that the periods don't mismatch for readability:
if kes_sk_period > provided_period {
return Err(ProtocolInitializerErrorWrapper::KesMismatch(
kes_sk_period,
provided_period,
));
}
// We need to perform the evolutions
for period in kes_sk_period..provided_period {
kes_sk
.update()
.map_err(|_| ProtocolInitializerErrorWrapper::KesUpdate(period))?;
}
Some(kes_sk.sign(&stm_initializer.verification_key().to_bytes()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR adapts the code to the new version of the KES library. Signatures and Public keys are compatible with older versions. However, secret keys are not. This should not be a backwards compatibility problem, as new nodes will still be compatible with older versions of the protocol and viceversa. However, secret keys serialised with the current library cannot be deserialised with an old version (or by the haskell node). The opposite, however, does work. New nodes will be able to deserialise previous file formats (or ones generated by the haskell node).
Pre-submit checklist