Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mislabeled critical error #833

Merged
merged 2 commits into from Mar 27, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 27, 2023

Content

This PR fixes a non critical error that has been mislabeled as critical error when the quorum is not reached for producing a multi-signature in the aggregator

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #824

When the computation of a multi-signature fails because the quorum is not reached.
@github-actions
Copy link

Test Results

    3 files  ±0    30 suites  ±0   6m 17s ⏱️ + 1m 6s
483 tests ±0  483 ✔️ ±0  0 💤 ±0  0 ±0 
559 runs  ±0  559 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e6d18ae. ± Comparison against base commit 44bbbeb.

@jpraynaud jpraynaud temporarily deployed to testing-preview March 27, 2023 10:27 — with GitHub Actions Inactive
@jpraynaud jpraynaud self-assigned this Mar 27, 2023
@jpraynaud jpraynaud merged commit b61945b into main Mar 27, 2023
23 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/824-fix-critical-error branch March 27, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants