Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greg/960/refacto digester #972

Merged
merged 6 commits into from Jun 9, 2023
Merged

Greg/960/refacto digester #972

merged 6 commits into from Jun 9, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Jun 8, 2023 •
edited

Content

This PR reshapes the immutable digester to require a path only when processing files.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #960

@ghubertpalo ghubertpalo self-assigned this Jun 9, 2023
@ghubertpalo ghubertpalo changed the title Greg/969/refacto digester Greg/960/refacto digester Jun 9, 2023
@ghubertpalo ghubertpalo force-pushed the greg/969/refacto_digester branch 3 times, most recently from 8846528 to ed5ade0 Compare June 9, 2023 09:27
@ghubertpalo ghubertpalo temporarily deployed to testing-preview June 9, 2023 12:29 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview June 9, 2023 13:14 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo force-pushed the greg/969/refacto_digester branch 2 times, most recently from 9948961 to a47037d Compare June 9, 2023 14:11
@ghubertpalo ghubertpalo temporarily deployed to testing-preview June 9, 2023 14:26 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit 8e117b1 into main Jun 9, 2023
23 checks passed
@ghubertpalo ghubertpalo deleted the greg/969/refacto_digester branch June 9, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring client
2 participants
@ghubertpalo @jpraynaud