Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mithril Client documentation #974

Merged
merged 3 commits into from Jun 12, 2023
Merged

Update Mithril Client documentation #974

merged 3 commits into from Jun 12, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 9, 2023 •
edited

Content

This PR includes some updates of the Mithril Client Documentation. It details the new commands related to the Mithril Stake Distribution.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Relates to #897

@dlachaume dlachaume force-pushed the damien/897-update-client-documentation-msd-commands branch 2 times, most recently from 0daca89 to 5e1d8df Compare June 12, 2023 09:50
jpraynaud
jpraynaud requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos 🙂

docs/root/manual/developer-docs/nodes/mithril-client.md Outdated Show resolved Hide resolved
docs/root/manual/developer-docs/nodes/mithril-client.md Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/897-update-client-documentation-msd-commands branch from 5e1d8df to 8b82994 Compare June 12, 2023 12:12
jpraynaud
jpraynaud approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 71113d6 into input-output-hk:main Jun 12, 2023
24 checks passed
@dlachaume dlachaume deleted the damien/897-update-client-documentation-msd-commands branch July 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dlachaume @jpraynaud