Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky end to end tests #977

Merged
merged 6 commits into from Jun 26, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 12, 2023

Content

This PR includes a fix to end to end tests flakiness that occurred because the aggregator was computing an open message with the wrong epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #954

@jpraynaud jpraynaud self-assigned this Jun 12, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch 6 times, most recently from 3e94950 to 44f92cb Compare June 14, 2023 14:09
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch 6 times, most recently from 39d93d7 to 6c692d9 Compare June 21, 2023 12:37
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch 4 times, most recently from fe10f70 to d7a4a77 Compare June 26, 2023 10:41
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 10:53 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review June 26, 2023 11:02
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 11:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch from d7a4a77 to e3ec0c2 Compare June 26, 2023 11:05
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 11:12 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 11:25 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 12:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 12:22 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch from e3ec0c2 to c4e84b8 Compare June 26, 2023 13:01
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 13:11 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch from c4e84b8 to 28cf470 Compare June 26, 2023 13:18
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 13:27 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/954-fix-flaky-tests-end-to-end branch from 28cf470 to 16a03fc Compare June 26, 2023 14:12
@jpraynaud jpraynaud temporarily deployed to testing-preview June 26, 2023 14:26 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 2aee4c5 into main Jun 26, 2023
23 of 30 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/954-fix-flaky-tests-end-to-end branch June 26, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End to end tests are flaky
2 participants