Greg/967/stake distribution artifact #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubertpalo
force-pushed
the
greg/967/stake_distribution_artifact
branch
2 times, most recently
from
0810db0
to
69a7170
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
force-pushed
the
greg/967/stake_distribution_artifact
branch
from
5233ca2
to
d3b42bb
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
requested changes
Jun 16, 2023
| @@ -62,6 +62,7 @@ export default function MithrilStakeDistributionsList(props) { | |||
| <Card.Title>{mithrilStakeDistribution.hash}</Card.Title> | |||
| <ListGroup variant="flush" className="data-list-group"> | |||
| <ListGroup.Item>Epoch: {mithrilStakeDistribution.epoch}</ListGroup.Item> | |||
| <ListGroup.Item>Created: {mithrilStakeDistribution.created_at}</ListGroup.Item> | |||
There was a problem hiding this comment.
Maybe we can add this in a separate PR if this is a breaking change for the explorer?
This may break the pre-release and release environments until they run this PR.
There was a problem hiding this comment.
Alternatively you can show this field only if it exist with something like this (note the usage of the date function to show the date to the user using his timezone & format):
{mithrilStakeDistribution.created_at &&
<ListGroup.Item>Created: {new Date(mithrilStakeDistribution.created_at).toLocaleString()}</ListGroup.Item>
}There was a problem hiding this comment.
This commit has been isolated into a new branch so we can deploy the explorer on its own.
ghubertpalo
force-pushed
the
greg/967/stake_distribution_artifact
branch
from
5a3f582
to
d3b42bb
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
force-pushed
the
greg/967/stake_distribution_artifact
branch
from
fee9669
to
96d8f2e
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR adds missing fields in the StakeDistribution signed entities. It will ease the forging of the signature on the client.
Pre-submit checklist
Comments
This is code refactoring, it will not change the user experience.
Issue(s)
Closes #967