fix hanging critical error #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
force-pushed
the
greg/993/aggregator_critical_error
branch
from
7533f3a
to
1a8c8fc
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
approved these changes
Jun 20, 2023
| @@ -244,7 +244,7 @@ impl ServeCommand { | |||
| let _ = shutdown_tx.send(()); | |||
|
|
|||
| info!("Event store is finishing..."); | |||
| event_store_thread.await?; | |||
| event_store_thread.await.unwrap(); | |||
There was a problem hiding this comment.
Is there any specific reason why you unwrapped here?
There was a problem hiding this comment.
yes, it should not change anything since the event store returns Ok(()) I wanted to make it to fail as fast as possible in case of … whatever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes...
Pre-submit checklist
Comments
None
Issue(s)
Closes #993