Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use local variable in prepareTx #929

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: use local variable in prepareTx #929

merged 2 commits into from
Mar 5, 2024

Conversation

lucas-barros
Copy link
Contributor

@lucas-barros lucas-barros commented Mar 5, 2024 •
edited
Loading

Fixes LW-9943 and LW-9936
Use local variable inside prepareTx instead of the one inside closure.

@lucas-barros lucas-barros marked this pull request as ready for review March 5, 2024 15:02
renanvalentin
renanvalentin approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@renanvalentin renanvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mkazlauskas
mkazlauskas approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ideally this (any many other) function would be hoisted to outside scope to avoid name clashes, but at this point it's probably safer not to touch it when we can avoid it 😅

@lucas-barros lucas-barros merged commit 501e501 into main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@renanvalentin renanvalentin renanvalentin approved these changes

@bslabiak bslabiak bslabiak approved these changes

@DominikGuzei DominikGuzei Awaiting requested review from DominikGuzei

@VanessaPC VanessaPC Awaiting requested review from VanessaPC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucas-barros @mkazlauskas @renanvalentin @bslabiak