Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the code based on upstreamed packet-python PRs #14

Closed
wants to merge 3 commits into from

Conversation

grahamc
Copy link
Contributor

@grahamc grahamc commented Feb 14, 2020

I upstreamed most of the patches in packethost/packet-python@03165b2...0aa7e7e (input-output-hk:hardware-reservation's branch at this time) in PRs:

The only commit in packethost/packet-python@03165b2...0aa7e7e I didn't backport is packethost/packet-python@e8bd416, because it is quite gnarly and I think working around an upstream issue -- I'm not sure. Anyway, this change to reservationId is the only thing I think needed -- and the second commit is just the way I've been testing the integrated branch.

Probably shouldn't merge this for now, and instead just use the upstream release once it is done.

@johnalotoski
Copy link
Contributor

The reservationId change has been applied to master. We're pointing to the v1.42.0-patched branch of our packet-python fork as we need the project keys fix commit for now (input-output-hk/packet-python@4baec99 on that branch).

@grahamc grahamc closed this Jun 24, 2020
@grahamc grahamc deleted the pr-scratch branch June 24, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants