connect for named pipes #1881
Merged
connect for named pipes #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1874. |
dcoutts
requested changes
Mar 31, 2020
4 tasks
This patch makes it much easier to run multiple clients against the same server.
There is a name clash between windows and posix naming convention, now we have both `connect` and `connectNamedPipe` (which serves as `accept` posix call).
It is confusing to export both `connect` and `createFile`.
coot
force-pushed
the
coot/Win32-network-connect
branch
from
49735ad
to
e580d3d
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 31, 2020
1881: connect for named pipes r=coot a=coot `connect` as designed in [https://docs.microsoft.com/en-us/windows/win32/ipc/named-pipe-client](MSDN's named-pipe-client). - Win32-netork: do not re-export createFile from NamedPipes module - Added System.Win32.NamedPipe.connect - Added waitNamedPipe Win32 syscall - Modify demo-chain-sync There's more than needed, I'll need to rebase this branch when #1876 gets merged to get rid of this patches: - Use sensible buffer sizes for Windows named pipes Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Canceled |
|
bors merge |
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Mar 31, 2020
742: Windows fixes from latest network package r=dcoutts a=dcoutts - [x] sensible pipe buffer size IntersectMBO/ouroboros-network#1876 - [ ] to more reliably connect to the node with multiple clients simultaneously IntersectMBO/ouroboros-network#1881 - [ ] a fix/workaround for the "DNS getting stuck on the second go on windows" problem IntersectMBO/ouroboros-network#1878 - [x] a timeout in the wait case of chain sync IntersectMBO/ouroboros-network#1871 Co-authored-by: Duncan Coutts <duncan@well-typed.com>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Mar 31, 2020
1523: Sync with libs used by cardano-node-1.9.3 r=KtorZ a=dcoutts This includes the various fixes to the Windows named pipe support. Most of those fixes were only relevant for the server side, i.e. the node, but one of them is relevant for the client side too. IntersectMBO/ouroboros-network#1881 In particular this changes how we connect to a named pipe so that if the pipe instance is not initially available then it'll wait and retry. This is genuinely the MSDN recommended way to do it 🤦♂️. Otherwise there's a race condition when multiple clients connect, or a client established multiple connections quickly after each other. Co-authored-by: Duncan Coutts <duncan@well-typed.com> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this pull request
Mar 31, 2020
1523: Sync with libs used by cardano-node-1.9.3 r=disassembler a=dcoutts This includes the various fixes to the Windows named pipe support. Most of those fixes were only relevant for the server side, i.e. the node, but one of them is relevant for the client side too. IntersectMBO/ouroboros-network#1881 In particular this changes how we connect to a named pipe so that if the pipe instance is not initially available then it'll wait and retry. This is genuinely the MSDN recommended way to do it 🤦♂️. Otherwise there's a race condition when multiple clients connect, or a client established multiple connections quickly after each other. Co-authored-by: Duncan Coutts <duncan@well-typed.com> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectas designed in[https://docs.microsoft.com/en-us/windows/win32/ipc/named-pipe-client](MSDN's
named-pipe-client).
There's more than needed, I'll need to rebase this branch when #1876 gets
merged to get rid of this patches: