Switch CI to GHC 8.10.2 #2540

mrBliss · 2020-08-25T16:25:32Z

Update the dependencies to versions compatible with GHC 8.10.2.

Switch over CI to GHC 8.10.2.

mrBliss · 2020-08-25T16:26:12Z

Draft because it includes #2539 and #2542 until they have been merged and because it relies on unmerged revisions of dependencies.

mrBliss · 2020-08-26T16:48:02Z

This PR is out of date. #2542 has been merged. Once #2547 and/or #2539 are merged, I'll update/rebase this PR.

coot · 2020-09-14T03:41:38Z

Is this pr stale?

mrBliss · 2020-10-01T07:48:15Z

I have updated this PR. It currently contains #2652 until that is merged.

ouroboros-consensus-test/test-consensus/Test/Consensus/HardFork/Combinator/A.hs

ouroboros-consensus/ouroboros-consensus.cabal

coot · 2020-10-01T09:08:00Z

Failed to build Win32-2.8.3.0. - maybe we should try a newer version? There's 2.10 available on hackage.

mrBliss · 2020-10-01T09:11:00Z

Failed to build Win32-2.8.3.0. - maybe we should try a newer version? There's 2.10 available on hackage.

Feel free to push a fix to this PR 🙂

coot · 2020-10-01T10:09:41Z

We need to either wait for 8.10.3 or apply this fix ourselves: https://www.stackage.org/blog/2020/08/ghc-8-10-2-windows-workaround

mrBliss · 2020-10-06T15:51:40Z

I have rebased the PR against master.

This will include the patch that was added in input-output-hk/haskell.nix#870 to fix this issue: ``` remote-iserv.exe: | /nix/store/kiljkg0bh7kc5cp5a0cqkshnabnfh73c-mingw-w64-6.0.0-x86_64-w64-mingw32/lib/libmingw32.a: unknown symbol `__acrt_iob_func' remote-iserv.exe: | /nix/store/kiljkg0bh7kc5cp5a0cqkshnabnfh73c-mingw-w64-6.0.0-x86_64-w64-mingw32/lib/libmingwex.a: unknown symbol `__mingw_raise_matherr' remote-iserv.exe: | /nix/store/bkfn9c3pn25n3kf4s1x0bw14v5f0dm1r-x86_64-w64-mingw32-ghc-8.10.2/lib/x86_64-w64-mingw32-ghc-8.10.2/ghc-prim-0.6.1/HSghc-prim-0.6.1.o: unknown symbol `exp' ```

This will include the patch that was added in input-output-hk/haskell.nix#874 to fix this issue: ``` Setup: The program 'pkg-config' version >=0.9.0 is required but it could not be found. builder for '/nix/store/16bf6j2f1fig368pi1yfv70x5njs8d6y-cardano-crypto-class-lib-cardano-crypto-class-2.0.0-x86_64-w64-mingw32.drv' failed with exit code 1 ```

GHC-8.10.2 comes with the wrong path for `ld.exe`: https://gitlab.haskell.org/ghc/ghc/-/issues/18550#note_293049

mrBliss · 2020-10-16T13:17:35Z

If CI turns green, we will finally be ready to switch to GHC 8.10.2 🎉

Many thanks again to @hamishmack and @coot for making this possible.

coot · 2020-10-16T13:24:40Z

Many thanks again to @hamishmack and @coot for making this possible.

Many thanks to you @mrBliss for pushing this forward!

mrBliss · 2020-10-16T14:40:20Z

There is one testsuite that's taking forever in CI: Cardano:ouroboros-network-pr-2540:x86_64-w64-mingw32.haskellPackages.ouroboros-network-framework.coverageReport.x86_64-linux

typed-protocols
  Network.Typed.Protocol.PingPong.Codec.Cbor

...

  Subscription
    Resolve (Sim):                                             OK (0.04s)
      +++ OK, passed 100 tests.
      
      Resolution Result (100 in total):
      32% A success, AAAA error
      22% A error, AAAA success
      19% A and AAAA error
       9% AAAA before A (Resolution Delay)
       8% A before AAAA
       7% AAAA before A
       3% A error, AAAA no result
    Resolve Subscribe (IO):                                    OK (5.88s)
      +++ OK, passed 100 tests.
    Send Recive with Dns worker (IO):                          OK (12.73s)
      +++ OK, passed 100 tests.

and then it hangs.

The next property to test is prop_send_recv_init_and_rsp.

This same test has timed out before: https://hydra.iohk.io/build/4447199/nixlog/2 (same branch).

@coot Do you know what could be wrong?

BTW, this test is not mandatory for CI. It is mingw32, but it passes in the native Windows CI, so we could merge this PR regardless.

mrBliss · 2020-10-16T14:46:12Z

bors merge

iohk-bors · 2020-10-16T14:46:16Z

👎 Rejected by too few approved reviews

coot

LGTM, though majority of changes are in consensus (or nix).

mrBliss · 2020-10-16T14:50:17Z

bors merge

iohk-bors · 2020-10-16T15:05:55Z

Build succeeded:

mark-stopka · 2020-10-16T15:26:52Z

Congratulations guys! @mrBliss and @coot for your patience, I hope me and @mimi1vx will be able to contribute more and more... especially if DC fund approves #dCloud forward, I have already spoke with Alex from Ergo about incirporating Ergo NIPoPoW from Ergo to Cardano... then the other way around Ouroboros Praos -> Ergo...

Our goal currently is to make Daedalus available as RPM package in openSUSE and CentOS, possibly also Ubuntu later... + add a ton of integration testing in this new repo...

https://github.com/2nd-Layer/cardano-core-integration-testing

@CharlesHoskinson as we are such a "friends", are there people at IOG I could use as point of contacts as we move forward? If you read the (sadly Czech) article, our partner / competitor, Invictus Mining has 330M CZK (14M USD) budget (incl. HW capex) to build either a dCloud or an altrnative to dCloud on other main chain, either way if dCloud won't get funded I would be joining their team do build the storage piece... We both know Decentralized Software Updates & Voltaire will need a storage solution, can we start the conversation about that over here?

input-output-hk/decentralized-software-updates#150

The main change this brings in is IntersectMBO/ouroboros-network#2540, which makes ouroboros-network fully compatible with GHC 8.10.2. Other noticeable changes: * `nodeBlockFetchSize` was renamed to `estimateBlockSize` (and is part of a different type class). * New `ClientTerminating` constructor of `TraceFetchClientState`. * New `TraceControlMessage` constructor of `TraceTxSubmissionOutbound`. * Added missing `COMPLETE` pragma for `CardanoLedgerState`.

2540: Switch CI to GHC 8.10.2 r=mrBliss a=mrBliss Update the dependencies to versions compatible with GHC 8.10.2. Switch over CI to GHC 8.10.2. Co-authored-by: Thomas Winant <thomas@well-typed.com> Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com> Co-authored-by: Marcin Szamotulski <profunctor@pm.me>

mrBliss requested review from coot, dcoutts and nc6 August 25, 2020 16:25

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch 3 times, most recently from 8d76e57 to 14cc11d Compare August 25, 2020 17:06

mrBliss mentioned this pull request Aug 25, 2020

Make network layer compatible with GHC 8.10 #2539

Merged

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch 5 times, most recently from 370d09b to ec7ad6a Compare September 7, 2020 17:22

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch from ec7ad6a to 19c69f8 Compare October 1, 2020 07:47

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch 3 times, most recently from bc02d39 to ad3fb7b Compare October 1, 2020 08:54

coot reviewed Oct 1, 2020

View reviewed changes

ouroboros-consensus-test/test-consensus/Test/Consensus/HardFork/Combinator/A.hs Show resolved Hide resolved

coot reviewed Oct 1, 2020

View reviewed changes

ouroboros-consensus/ouroboros-consensus.cabal Show resolved Hide resolved

mrBliss mentioned this pull request Oct 2, 2020

Update haskell.nix and fix windows cross #2655

Closed

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch from b511a57 to 427082f Compare October 6, 2020 15:50

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch from 427082f to 720478f Compare October 7, 2020 06:28

hamishmack mentioned this pull request Oct 7, 2020

Also upgrade to nixpkgs 20.09 #2673

Merged

hamishmack and others added 6 commits October 16, 2020 15:12

Replace * with Type

079402d

Update haskell.nix to include #878

e975c6b

Fix Windows GitHub workflow

c779c4e

GHC-8.10.2 comes with the wrong path for `ld.exe`: https://gitlab.haskell.org/ghc/ghc/-/issues/18550#note_293049

Make Win32-network compile with GHC 8.10.2

ffb4bc3

mrBliss force-pushed the mrBliss/switch-ghc-8.10 branch from fb0a031 to ffb4bc3 Compare October 16, 2020 13:12

mrBliss marked this pull request as ready for review October 16, 2020 13:14

mrBliss requested a review from coot October 16, 2020 14:48

coot approved these changes Oct 16, 2020

View reviewed changes

iohk-bors bot merged commit 4827c38 into master Oct 16, 2020

iohk-bors bot deleted the mrBliss/switch-ghc-8.10 branch October 16, 2020 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch CI to GHC 8.10.2 #2540

Switch CI to GHC 8.10.2 #2540

mrBliss commented Aug 25, 2020

mrBliss commented Aug 25, 2020 •

edited

mrBliss commented Aug 26, 2020

coot commented Sep 14, 2020

mrBliss commented Oct 1, 2020 •

edited

coot commented Oct 1, 2020

mrBliss commented Oct 1, 2020

coot commented Oct 1, 2020

mrBliss commented Oct 6, 2020

mrBliss commented Oct 16, 2020

coot commented Oct 16, 2020

mrBliss commented Oct 16, 2020 •

edited

mrBliss commented Oct 16, 2020

iohk-bors bot commented Oct 16, 2020

coot left a comment

mrBliss commented Oct 16, 2020

iohk-bors bot commented Oct 16, 2020

mark-stopka commented Oct 16, 2020 •

edited

Switch CI to GHC 8.10.2 #2540

Switch CI to GHC 8.10.2 #2540

Conversation

mrBliss commented Aug 25, 2020

mrBliss commented Aug 25, 2020 • edited

mrBliss commented Aug 26, 2020

coot commented Sep 14, 2020

mrBliss commented Oct 1, 2020 • edited

coot commented Oct 1, 2020

mrBliss commented Oct 1, 2020

coot commented Oct 1, 2020

mrBliss commented Oct 6, 2020

mrBliss commented Oct 16, 2020

coot commented Oct 16, 2020

mrBliss commented Oct 16, 2020 • edited

mrBliss commented Oct 16, 2020

iohk-bors bot commented Oct 16, 2020

coot left a comment

Choose a reason for hiding this comment

mrBliss commented Oct 16, 2020

iohk-bors bot commented Oct 16, 2020

mark-stopka commented Oct 16, 2020 • edited

mrBliss commented Aug 25, 2020 •

edited

mrBliss commented Oct 1, 2020 •

edited

mrBliss commented Oct 16, 2020 •

edited

mark-stopka commented Oct 16, 2020 •

edited