BlockFetch protocol limit #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
added
block-fetch
karknu
reviewed
Sep 21, 2020
coot
force-pushed
the
coot/block-fetch-protocol-limits
branch
from
ffb4508
to
f8970b3
Compare
There was a problem hiding this comment.
I have a concern as to how this may effect bulk download. Correct me if I'm wrong, but this represents the total data in flight during a bulk block fetch; I assume that we are ack-ing the blocks (probably implicitly by asking for more). This makes it analogous to the role of the TCP congestion window (from a performance perspective). My concern is will 6.4Mb of inflight data be sufficient to hide latency to achieve reasonable throughput for peers that are "reasonably" distant (i.e not in same data centre, but on same continent).
|
bors merge |
|
👎 Rejected by too few approved reviews |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block fetch limit is set according to: https://docs.google.com/spreadsheets/d/1W0PJCYPan8smSg_CnuG-fQVFOnb7DzQhm3W1LuVTZR4/edit?pli=1#gid=0