Use uninterruptibleCancel in JobPool #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of ListLike is not compatible with bytestring-0.10.12.0 or newer: ddssff/listlike#13
coot
force-pushed
the
coot/job-pool-uninterruptibleCancel
branch
from
9799742
to
0e1ac6b
Compare
|
bors merge |
|
Build succeeded: |
coot
added a commit
that referenced
this pull request
May 16, 2022
2851: Use uninterruptibleCancel in JobPool r=coot a=coot JobPool is using bracket which requires that the resource finalizer is uninterruptible. Could this introduce a deadlock? I don't think so, only if there already was a deadlock which forbid to deliver asynchronous exception. This could happen either deadlock in FFI, or a tight loop which does not allocate. Both `async` library is using `uninterruptibleCancel` in `withAsync` combinator, and `ouroboros-consensus` is using it as well in their more sophisticated version of `ResourceRegistery`. - ouroboros-network:cddl: ListLike bound - job-pool: use uninterruptible handler in bracket Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JobPool is using bracket which requires that the resource finalizer is
uninterruptible. Could this introduce a deadlock? I don't think so, only if
there already was a deadlock which forbid to deliver asynchronous exception.
This could happen either deadlock in FFI, or a tight loop which does not
allocate.
Both
asynclibrary is usinguninterruptibleCancelinwithAsynccombinator, and
ouroboros-consensusis using it as well in their moresophisticated version of
ResourceRegistery.