Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for V7 keepalive #3193

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Add support for V7 keepalive #3193

merged 1 commit into from
Jun 2, 2021

Conversation

karknu
Copy link
Contributor

@karknu karknu commented May 28, 2021

NodeToNode version 7 fixed the cbor encoding for the keepalive
miniprotocol.

@karknu
Copy link
Contributor Author

karknu commented May 28, 2021

Fixes #3187.

@karknu karknu requested a review from coot May 28, 2021 08:54
@karknu karknu marked this pull request as ready for review May 28, 2021 08:54
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request May 31, 2021
@jbgi
Copy link
Contributor

jbgi commented May 31, 2021

tested successfully on alonzo-blue.

network-mux/demo/cardano-ping.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NodeToNode version 7 fixed the cbor encoding for the keepalive
miniprotocol.
@karknu
Copy link
Contributor Author

karknu commented Jun 2, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 2, 2021

@iohk-bors iohk-bors bot merged commit e506135 into master Jun 2, 2021
@iohk-bors iohk-bors bot deleted the karknu/cardano-ping-v7 branch June 2, 2021 09:45
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Jun 3, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Jul 13, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Jul 19, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Aug 5, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Aug 6, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Aug 10, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Aug 12, 2021
jbgi added a commit to input-output-hk/cardano-ops that referenced this pull request Aug 13, 2021
coot pushed a commit that referenced this pull request May 16, 2022
3193: Add support for V7 keepalive r=karknu a=karknu

NodeToNode version 7 fixed the cbor encoding for the keepalive
miniprotocol.

Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants