Move TPraos protocol into its own package. #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
requested review from
bolt12,
coot,
EncodePanda and
karknu
as code owners
nfrisby
reviewed
Dec 3, 2021
| @@ -8,7 +8,7 @@ | |||
| -- | Hot key | |||
| -- | |||
| -- Intended for qualified import | |||
| module Ouroboros.Consensus.Shelley.Protocol.HotKey ( | |||
| module Ouroboros.Consensus.Protocol.Ledger.HotKey ( | |||
There was a problem hiding this comment.
Thinking out loud: is the hotkey more a Ledger concern or more a BlockForging concern?
Actually, I'm less sure how to distinguish which parts of this are unique to BlockForging than I had thought I was. EG only a block-producing node would ever use evolve, sign, and mkHotKey, if I understand correctly.
I suppose it's natural to leave this module unbroken, and so Ledger really is the most appropriate point in the conceptual hierarchy for this bag of definitions.
There was a problem hiding this comment.
Yeah, I think I might end up moving some of this logic around anyway. Currently forging isn't really keyed to the protocol, only to the block.
nc6
force-pushed
the
nc/extract-protocol
branch
from
b200f80
to
df2700e
Compare
nfrisby
approved these changes
Dec 6, 2021
nc6
force-pushed
the
nc/extract-protocol
branch
from
df2700e
to
6c5becb
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 7, 2021
3513: Move TPraos protocol into its own package. r=nc6 a=nc6 Intention will be to implement the new Praos protocol also in this package. This PR simply moves things around. I didn't move the PBFT protocol into this package, since it seemed reasonable to just isolate it in Byron. Co-authored-by: Nicholas Clarke <nick@topos.org.uk>
|
Build failed: |
Intention will be to implement the new Praos protocol also in this package.
nc6
force-pushed
the
nc/extract-protocol
branch
from
6c5becb
to
134bf3a
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intention will be to implement the new Praos protocol also in this package.
This PR simply moves things around. I didn't move the PBFT protocol into this package, since it seemed reasonable to just isolate it in Byron.