Avoid ordering peers based on peerid in blockfetch #3535
Merged
+79
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/blockfetch_order_p2p_master_1.31.0
branch
3 times, most recently
from
5e96fbf
to
bedc555
Compare
coot
requested changes
Jan 14, 2022
ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/Types.hs
Outdated
Show resolved
Hide resolved
karknu
force-pushed
the
karknu/blockfetch_order_p2p_master_1.31.0
branch
from
bedc555
to
5463dcf
Compare
coot
reviewed
Jan 18, 2022
karknu
force-pushed
the
karknu/blockfetch_order_p2p_master_1.31.0
branch
from
5463dcf
to
7d18f64
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 20, 2022
3535: Avoid ordering peers based on peerid in blockfetch r=coot a=karknu Peers where ordered based on SockAddr, which generally meant that all peers would pick the same second choice peer to download blocks from in Deadline mode. And the same third pick and so on. This changes ranking so that peers are sorted based on G. Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
|
bors cancel |
|
Canceled. |
Peers where ordered based on SockAddr, which generally meant that all peers would pick the same second choice peer to download blocks from in Deadline mode. And the same third pick and so on. This changes ranking so that peers are sorted based on G.
In case two peer's G where close to each other the ordering wasn't stable. This fixes the ordering and adds matching tests.
karknu
force-pushed
the
karknu/blockfetch_order_p2p_master_1.31.0
branch
from
7d18f64
to
8bb40ce
Compare
karknu
requested review from
bolt12,
EncodePanda,
newhoggy,
nfrisby,
njd42 and
a team
as code owners
|
bors r+ |
|
Build succeeded: |
|
Fixes #3536 |
karknu
added a commit
that referenced
this pull request
Jan 21, 2022
3535: Avoid ordering peers based on peerid in blockfetch r=karknu a=karknu Peers where ordered based on SockAddr, which generally meant that all peers would pick the same second choice peer to download blocks from in Deadline mode. And the same third pick and so on. This changes ranking so that peers are sorted based on G. Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
4 tasks
coot
pushed a commit
that referenced
this pull request
May 16, 2022
3535: Avoid ordering peers based on peerid in blockfetch r=karknu a=karknu Peers where ordered based on SockAddr, which generally meant that all peers would pick the same second choice peer to download blocks from in Deadline mode. And the same third pick and so on. This changes ranking so that peers are sorted based on G. Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peers where ordered based on SockAddr, which generally meant that all
peers would pick the same second choice peer to download blocks from in
Deadline mode. And the same third pick and so on.
This changes ranking so that peers are sorted based on G.