Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Test.Util.Classify in favour of Test.StateMachine.Labelling. #4429

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Remove Test.Util.Classify in favour of Test.StateMachine.Labelling. #4429

merged 1 commit into from
Mar 7, 2023
+5 −115

Conversation

jorisdral
Copy link
Contributor

Description

The Test.Util.Classify module contains practically the same code as Test.StateMachine.Labelling from quickcheck-state-machine (see the source) . This PR removes the Test.Util.Classify module, and makes test modules import Test.StateMachine.Labelling instead.

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
    • Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers.
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@jorisdral jorisdral added the maintenance Issues / PRs related to maintenance of any of the compoents. label Mar 3, 2023
@jorisdral jorisdral requested a review from nfrisby as a code owner March 3, 2023 17:45
@jorisdral jorisdral self-assigned this Mar 3, 2023
@jorisdral jorisdral requested a review from dnadales as a code owner March 3, 2023 17:45
@jorisdral jorisdral requested review from a team and removed request for dnadales and nfrisby March 3, 2023 17:45
jasagredo
jasagredo approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jorisdral jorisdral force-pushed the jdral/remove-test-util-classify branch from 97d6661 to fc56e17 Compare March 6, 2023 14:23
dnadales
dnadales approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@dnadales dnadales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@jorisdral
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 7, 2023
@iohk-bors @jorisdral
Merge #4429
987ed89 
4429: Remove `Test.Util.Classify` in favour of `Test.StateMachine.Labelling`. r=jorisdral a=jorisdral

# Description

The `Test.Util.Classify` module contains practically the same code as `Test.StateMachine.Labelling` from `quickcheck-state-machine` (see the [source](https://hackage.haskell.org/package/quickcheck-state-machine-0.7.1/docs/src/Test.StateMachine.Labelling.html)) . This PR removes the `Test.Util.Classify` module, and makes test modules import `Test.StateMachine.Labelling` instead.



Co-authored-by: Joris Dral <joris@well-typed.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 7, 2023

Timed out.

@jorisdral
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 7, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9e0e5c8 into master Mar 7, 2023
@iohk-bors iohk-bors bot deleted the jdral/remove-test-util-classify branch March 7, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnadales dnadales dnadales approved these changes

@jasagredo jasagredo jasagredo approved these changes

Assignees

@jorisdral jorisdral

Labels
maintenance Issues / PRs related to maintenance of any of the compoents.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorisdral @dnadales @jasagredo