-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Test.Util.Classify
in favour of Test.StateMachine.Labelling
.
#4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
added
the
maintenance
Issues / PRs related to maintenance of any of the compoents.
label
Mar 3, 2023
jorisdral
requested review from
a team
and removed request for
dnadales and
nfrisby
March 3, 2023 17:45
jasagredo
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
jorisdral
force-pushed
the
jdral/remove-test-util-classify
branch
from
March 6, 2023 14:23
97d6661
to
fc56e17
Compare
dnadales
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 7, 2023
4429: Remove `Test.Util.Classify` in favour of `Test.StateMachine.Labelling`. r=jorisdral a=jorisdral # Description The `Test.Util.Classify` module contains practically the same code as `Test.StateMachine.Labelling` from `quickcheck-state-machine` (see the [source](https://hackage.haskell.org/package/quickcheck-state-machine-0.7.1/docs/src/Test.StateMachine.Labelling.html)) . This PR removes the `Test.Util.Classify` module, and makes test modules import `Test.StateMachine.Labelling` instead. Co-authored-by: Joris Dral <joris@well-typed.com>
Timed out. |
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Test.Util.Classify
module contains practically the same code asTest.StateMachine.Labelling
fromquickcheck-state-machine
(see the source) . This PR removes theTest.Util.Classify
module, and makes test modules importTest.StateMachine.Labelling
instead.Checklist
changelog.d
directory created usingscriv
. If in doubt, see the Consensus release process.DEPRECATED
warning that notifies downstream consumers.interface-CHANGELOG.md