Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-ping trace log changes #4593

Merged
merged 3 commits into from
Jun 12, 2023
Merged

cardano-ping trace log changes #4593

merged 3 commits into from
Jun 12, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 12, 2023

  • cardano-ping: printing of negotiated version
  • cardano-ping: formatting of StatPoint
  • cardano-ping: updated CHANGELOG.md file

@coot coot requested a review from bolt12 June 12, 2023 08:34
@coot
Copy link
Contributor Author

coot commented Jun 12, 2023

cardano-cli ping -h $(resolvectl query --raw coot.me -4 | awk '{print $2}') -p 7776 -c 5            
95.217.1.58:7776 network rtt: 0.062
95.217.1.58:7776 handshake rtt: 0.067647887s
95.217.1.58:7776 Negotiated version NodeToNodeVersionV11 764824073 InitiatorOnly
timestamp,                      host,                         cookie,  sample,  median,     p90,    mean,     min,     max,     std
2023-06-12T08:37:28.205318946Z, 95.217.1.58:7776,                  0,   0.069,   0.069,   0.069,   0.069,   0.069,   0.069,     NaN
2023-06-12T08:37:29.265466863Z, 95.217.1.58:7776,                  1,   0.059,   0.064,   0.068,   0.064,   0.059,   0.069,   0.007
2023-06-12T08:37:30.328873883Z, 95.217.1.58:7776,                  2,   0.062,   0.063,   0.068,   0.063,   0.059,   0.069,   0.005
2023-06-12T08:37:31.390815961Z, 95.217.1.58:7776,                  3,   0.061,   0.061,   0.068,   0.063,   0.059,   0.069,   0.004
2023-06-12T08:37:32.451068867Z, 95.217.1.58:7776,                  4,   0.059,   0.061,   0.067,   0.062,   0.059,   0.069,   0.004
cardano-cli ping -h $(resolvectl query --raw coot.me -4 | awk '{print $2}') -p 7776 --query-versions
95.217.1.58:7776 network rtt: 0.064
95.217.1.58:7776 handshake rtt: 0.064010896s
95.217.1.58:7776 Queried versions [NodeToNodeVersionV11 764824073 InitiatorAndResponder,NodeToNodeVersionV10 764824073 InitiatorAndResponder,NodeToNodeVersionV9 764824073 Initiat
orAndResponder,NodeToNodeVersionV8 764824073 InitiatorAndResponder,NodeToNodeVersionV7 764824073 InitiatorAndResponder]

When querying an older node which doesn't support --query-versions, the negotiated version is printed:

34.245.250.174:3001 network rtt: 0.045
34.245.250.174:3001 handshake rtt: 0.101867615s
34.245.250.174:3001 Negotiated version NodeToNodeVersionV10 764824073 InitiatorAndResponder

@coot coot added networking cardano-ping Iessues / PRs related to cardano-ping labels Jun 12, 2023
@coot coot changed the title coot/ping cmd cardano-ping trace log changes Jun 12, 2023
cardano-ping/src/Cardano/Network/Ping.hs Outdated Show resolved Hide resolved
coot added 2 commits June 12, 2023 10:55
It only makes sense to print the negotiation result if it happened on
the remote side.
@coot coot force-pushed the coot/ping-cmd branch 2 times, most recently from bf36af3 to 8280f07 Compare June 12, 2023 09:04
@coot coot added this pull request to the merge queue Jun 12, 2023
@coot coot merged commit dfcea03 into master Jun 12, 2023
6 checks passed
@coot coot deleted the coot/ping-cmd branch June 12, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cardano-ping Iessues / PRs related to cardano-ping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants