Fixed handshake query delay #4603
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/hanshake-query-shutdown-delay
branch
from
26f4824
to
239354c
Compare
bolt12
requested changes
Jun 23, 2023
bolt12
approved these changes
Jun 23, 2023
coot
force-pushed
the
coot/hanshake-query-shutdown-delay
branch
from
239354c
to
268f328
Compare
After handshake query the responder side is supposed to close the connection after 20s. We used wrong `threadDelay` function, and it waited only 20μs instead.
coot
force-pushed
the
coot/hanshake-query-shutdown-delay
branch
from
268f328
to
bf9dce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After handshake query the responder side is supposed to close the
connection after 20s. We used wrong
threadDelayfunction, and itwaited only 20μs instead.