Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay peersharing #4735

Closed
wants to merge 3 commits into from
Closed

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Nov 29, 2023

Description

Delay peer sharing for newly established peers for 5 minutes. The 5 minute gives the new peer plenty of time to prove itself useful, or violate the protocol and be disconnected.
This change also fixes a startup problem where, when the node starts it could end up asking the first peer it manages to connect to for 100 peers.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • [ x Reviewer requested

Peers are churned about once per hour so we can expect to have to ask
peers for new peers more often than that.
Delay peersharing for 5minutes for newly established peers.
@coot coot added the peer-sharing Issues / PRs related to peer sharing label Dec 8, 2023
@karknu karknu closed this Jan 22, 2024
@coot
Copy link
Contributor

coot commented Jan 22, 2024

These changes were merged in #4739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-sharing Issues / PRs related to peer sharing
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants