Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify types in the ledger DB #538

Merged
merged 1 commit into from
May 21, 2019
Merged

Clarify types in the ledger DB #538

merged 1 commit into from
May 21, 2019

Conversation

edsko
Copy link
Contributor

@edsko edsko commented May 21, 2019

When we reapply a block in the same state, this cannot result in an error.

@edsko edsko requested a review from mrBliss May 21, 2019 13:06
@edsko edsko force-pushed the edsko/clarify-PrevApplied branch 3 times, most recently from 1279eaa to 807a217 Compare May 21, 2019 13:13
When we reapply a block in the same state, this cannot result in an error.
@edsko edsko force-pushed the edsko/clarify-PrevApplied branch from 807a217 to 4df738c Compare May 21, 2019 13:18
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The changes were already discussed on Slack and Meet.

@edsko edsko merged commit 51ed090 into master May 21, 2019
@iohk-bors iohk-bors bot deleted the edsko/clarify-PrevApplied branch May 21, 2019 13:29
@edsko edsko mentioned this pull request May 21, 2019
mrBliss added a commit that referenced this pull request May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants