Updated Week1 code (EnglishAuction) to newer version of Plutus #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemo83
changed the title
nemo83
changed the title
nemo83
commented
May 26, 2021
Comment on lines
355
to
356
| test :: IO () | ||
| test = runEmulatorTraceIO' def emCfg myTrace |
There was a problem hiding this comment.
Planning to add more test combinations.
nemo83
changed the title
|
Hi @nemo83, I hope this message finds you well. I wanted to inform you that we have decided to close this pull request as it pertains to an old branch of the course. Please note that these branches are not actively maintained and are kept for historical purposes. We encourage you to utilize the branch that best suits your needs, whether it's the current version or any other relevant branch. Please don't hesitate to reach out if you have any questions or require further assistance. We're here to help! Thank you for your understanding and your valuable contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated EnglishAuction code to use more recent version of Plutus
As I am planning to implement an Auction Smart Contract myself, I've decided to give a shot and try to update the EnglishAuction code to better understand what's going on. Hopefully this could turn out handy for the next wave of Plutus Pioneer.
Of course I don't mind if the PR is rejected, but a review would be more than appreciated to check whether or not there are errors or improvements.
TODO:
Currently the error I can't fix is:
