Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cabal 3.4 #2774

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Update to cabal 3.4 #2774

merged 2 commits into from
Feb 25, 2021

Conversation

michaelpj
Copy link
Contributor

This makes source-repository-packages behave better.

Nothing to review for now, getting Hydra to build stuff for me.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • If you updated any cabal files or added Haskell packages:
    • nix-shell shell.nix --run updateMaterialized to update the materialized Nix files
    • Update hie-*.yaml files if needed
  • If you changed any Haskell files:
    • nix-shell shell.nix --run fix-stylish-haskell to fix any formatting issues
  • If you changed any Purescript files:
    • nix-shell shell.nix --run fix-purty to fix any formatting issues

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

We were printing based on the ordering of a hash map, which is not
guaranteed to be stable (e.g. it can change if the version of `hashable`
which we uses changes).
This makes source-repository-packages behave better.

Nothing to review for now, getting Hydra to build stuff for me.
@michaelpj michaelpj merged commit 357336d into master Feb 25, 2021
@kwxm kwxm deleted the imp/cabal-3.4 branch June 16, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant