Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the benchmark workflow #5203

Closed
wants to merge 1 commit into from
Closed

Conversation

michaelpj
Copy link
Contributor

The pre and post jobs don't need the benchmarking machine, and the
benchmarking machine bit that runs code from the repo has reduced permissions.

The logs are also available as an artifact.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

The pre and post jobs don't need the benchmarking machine, and the
benchmarking machine bit that runs code from the repo has reduced permissions.

The logs are also available as an artifact.
@michaelpj
Copy link
Contributor Author

/benchmark plutus-benchmark:nofib

@github-actions
Copy link
Contributor

Click here to check the status of your benchmark.

@kwxm
Copy link
Contributor

kwxm commented Nov 15, 2023

I think this is obsolete now.

@kwxm kwxm closed this Nov 15, 2023
@michaelpj
Copy link
Contributor Author

I do actually still think this is a good idea but it's not a big deal

@zeme-wana zeme-wana deleted the mpj/split-bench-workflow branch June 20, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants