This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
Make BlockStore usable as a trait object #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires getting rid of the generic type parameter in get_path_to_nth_ancestor(), dropping the Self return type in iterate_range() and dropping Sized.
mzabaluev
reviewed
Mar 13, 2019
| to_depth: to_info.depth, | ||
| cur_depth: to_info.depth - distance, | ||
| pending_infos: vec![to_info], | ||
| }) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // See https://stackoverflow.com/questions/42121299/provided-method-casting-self-to-trait-object | ||
| fn as_trait(&self) -> &BlockStore<Block = Self::Block>; |
There was a problem hiding this comment.
Note that there were a few other solutions that don't require a bogus method. I'd go with a helper blanket-implemented trait.
There was a problem hiding this comment.
you meant something like:
pub trait BlockStore {
fn as_trait(&self) -> &BlockStore<Block = Self::Block> { self }
}would that work ?
There was a problem hiding this comment.
That doesn't work since self is not Sized, and adding a Sized bound to as_trait makes it unavailable in trait objects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires getting rid of the generic type parameter in
get_path_to_nth_ancestor(), dropping theSelfreturn type initerate_range()and droppingSized.