This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Expose API types in a separate package #110
Comments
This was referenced Oct 29, 2020
Closed
iohk-bors bot
added a commit
to cardano-foundation/cardano-wallet
that referenced
this issue
Nov 3, 2020
2285: Reject SMASH URIs with paths r=hasufell a=hasufell # Issue Number ADP-502 # Overview * The idea was to use the servant types of SMASH, but that's pending due to input-output-hk/smash#110 # Comments This was tested locally against testnet. The sqlite serialisation is a little more permissive. Co-authored-by: Julian Ospald <julian.ospald@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
|
Resolved by #112 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Despite my best efforts to improve the building situation and the mock server, it was decided that the wallet won't be building against the whole smash lib for now, which I find sad, because it will mean to build a manual mock server and not be able to test against the real thing for now.
However, we still want to have access to the servant types, so we can call the endpoints nicely as a servant client with minimal dependencies. That'll still be quite useful and I've seen this approach in use in other companies too. I'm preparing a PR right now to split the packages, so you can see how it looks like and if you like it.
The text was updated successfully, but these errors were encountered: