Invalid output type

[KonstantinSviridov]

Hi, guys!
In
https://github.com/INRIA/spoon/blob/master/src/main/java/spoon/OutputType.java
we have NO_OUTPUT("noouput"), which pevents us from using this enum value.

[swolf91]

@KonstantinSviridov I don't get your intention with that issue. Is it because of the typo?

[KonstantinSviridov]

@boeserwolf91
Right. Don't you want to correct typos in your code? :-)

In my code I set command line parameters and I want to write something like

ArrayList<String> lst = new ArrayList<String>();
lst.add("--output-type");
lst.add(OutputType.NO_OUTPUT.toString());

but I can not.

Anyway, I would not have come here because of this typo only :-)

[swolf91]

Ah I see. Now I got you :) and just to clarify. It's not my code haha I'm not related to Inria.

I noticed the typo as I provided the pull request #64
I planned to refactor this class after this pull request was merged. I want to modify the method fromString because the names are duplicated. I'll correct the typo if I provide the other pull request after the current one was merged.

[swolf91]

@KonstantinSviridov by the way you could write something like the following for a workaround:

ArrayList<String> lst = new ArrayList<String>();
lst.add("--output-type");
lst.add(OutputType.NO_OUTPUT.name().toLowerCase().replaceAll("_",""));

[pschichtel]

It would be best to avoid duplicating the names in the enum

[swolf91]

I agree with @pschichtel

[GerardPaligot]

Oh ok, I got it now. This issue is about the typo.

Well, when the PR of @boeserwolf91 will be merged, we'll can fix that typo.

[pschichtel]

@GerardPaligot it would be better to drop the strings entirely

[GerardPaligot]

Indeed, they aren't very useful.