Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease code coverage threshold #984

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Jun 6, 2024

Dependency updates are being blocked because of a code coverage regression. This decreases the code coverage threshold until we spend the time going back to 100%.

PRs are being blocked because of a code coverage regression. This
decreases the code coverage threshold until we spend the time going back
to 100%.
@NSeydoux NSeydoux requested review from a team as code owners June 6, 2024 08:29
@NSeydoux NSeydoux requested review from pmcb55 and removed request for pmcb55 June 6, 2024 08:48
@NSeydoux NSeydoux enabled auto-merge (squash) June 6, 2024 13:52
Copy link
Contributor

@pmcb55 pmcb55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok (although I am interested to see where the coverage drop is coming from (I can't see it locally on main, and you didn't mention which dependency is causing it), but this is fine for now I guess).

@NSeydoux NSeydoux merged commit 48ac61c into main Jun 10, 2024
3 checks passed
@NSeydoux NSeydoux deleted the chore/decrease-coverage-threshold branch June 10, 2024 08:51
@NSeydoux
Copy link
Contributor Author

NSeydoux commented Jun 10, 2024

All of the dependabot PRs were failing with a coverage issue: e.g. https://github.com/inrupt/artifact-generator/actions/runs/9390357419/job/25860015133. I didn't run it locally, so I am not sure what the issue exactly is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants