Support Node 18 #2803
Merged
Support Node 18 #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the engines entry from the browser package, because it is a node-specific value, and added Node 18 in other packages.
This updates the transitive dependency on solid-client to the latest version, resolving the json-ld parser issues on Node 18
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
The test had a race condition because it was incorrectly waiting on an element to be set, resulting in a fetch potentially being unauthenticated.
NSeydoux
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
jeswr
approved these changes
Apr 15, 2023
mrkvon
added a commit
to OpenHospitalityNetwork/sleepy.bike
that referenced
this pull request
May 27, 2023
mrkvon
added a commit
to OpenHospitalityNetwork/sleepy.bike
that referenced
this pull request
May 27, 2023
also update @inrupt/solid-client-authn-browser to support latest Node inrupt/solid-client-authn-js#2803 but we still need to use Node v16, because of CSS CommunitySolidServer/CommunitySolidServer#1637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes support for Node 18 explicit by updating the package.json engines entry, and by introducing Node 18 in the test matrix.
This fixes #2374
Checklist