Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/export acp #1694

Merged
merged 2 commits into from Aug 31, 2022
Merged

feat/export acp #1694

merged 2 commits into from Aug 31, 2022

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Aug 30, 2022

  • feat: export WithAcp and WithAccessibleAcr
  • chore: update changelog

This PR fixes #.

  • [ NA ] I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@jeswr jeswr requested a review from a team as a code owner August 30, 2022 01:27
@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-client-js ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 1:27AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2aa1fef:

Sandbox Source
solid-client-sandbox Configuration

@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 02:04 Inactive
@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 02:04 Inactive
@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 02:04 Inactive
@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 04:55 Inactive
@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 04:55 Inactive
@jeswr jeswr temporarily deployed to Inrupt Dev-Next August 30, 2022 04:55 Inactive
ThisIsMissEm
ThisIsMissEm approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but wait for @matthieubosquet to review

@jeswr jeswr merged commit dceefc9 into main Aug 31, 2022
@jeswr jeswr deleted the feat/export-acp branch August 31, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMissEm ThisIsMissEm ThisIsMissEm approved these changes

@matthieubosquet matthieubosquet matthieubosquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeswr @ThisIsMissEm @matthieubosquet